Skip to content

Change codeowners for enterprise-search#40796

Merged
tutelaris merged 3 commits intoelastic:mainfrom
tutelaris:change-codeowners-enterprise-search
Sep 13, 2024
Merged

Change codeowners for enterprise-search#40796
tutelaris merged 3 commits intoelastic:mainfrom
tutelaris:change-codeowners-enterprise-search

Conversation

@tutelaris
Copy link
Member

@tutelaris tutelaris commented Sep 12, 2024

Description

As an initiative to rename teams in the Search org from ent-search-* to search-*, it's required to change the code owners here.

This PR is dedicated to changing the codeowners file.

@tutelaris tutelaris self-assigned this Sep 12, 2024
@tutelaris tutelaris requested a review from a team as a code owner September 12, 2024 17:35
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 12, 2024
@botelastic
Copy link

botelastic bot commented Sep 12, 2024

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @tutelaris? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
@tutelaris
Copy link
Member Author

tutelaris commented Sep 12, 2024

@elastic/ingest-eng-prod, can you please add @elastic/ent-search-application team to the repo?

@kderusso
Copy link
Member

kderusso commented Sep 12, 2024

@tutelaris - Do we want to use @elastic/ent-search-application or should we migrate to some of the newer groups, e.g. @elastic/search-relevance , @elastic/search-experiences , @elastic/search-extract-and-transform , and @elastic/search-inference-team ? Alternately should we consider renaming to something like @elastic/search-team?

@rowlandgeoff
Copy link
Contributor

rowlandgeoff commented Sep 12, 2024

@elastic/ingest-eng-prod, can you please add @elastic/ent-search-application team to the repo?

@tutelaris Done. elastic/ent-search-application team now have write access. Shall I remove access for elastic/ent-search-application-backend? (Probably after you merge?) Or... is this going to change again based on Kathleen's comment?

@tutelaris
Copy link
Member Author

tutelaris commented Sep 13, 2024

@tutelaris - Do we want to use @elastic/ent-search-application or should we migrate to some of the newer groups, e.g. @elastic/search-relevance , @elastic/search-experiences , @elastic/search-extract-and-transform , and @elastic/search-inference-team ? Alternately should we consider renaming to something like @elastic/search-team?

We decided to keep the @elastic/ent-search-application team to match with @app-search-team team in Slack

@tutelaris
Copy link
Member Author

tutelaris commented Sep 13, 2024

@elastic/ingest-eng-prod, can you please add @elastic/ent-search-application team to the repo?

@tutelaris Done. elastic/ent-search-application team now have write access. Shall I remove access for elastic/ent-search-application-backend? (Probably after you merge?) Or... is this going to change again based on Kathleen's comment?

Thank you!
No, you can remove the backend team.

@tutelaris tutelaris added backport and removed backport-8.x Automated backport to the 8.x branch with mergify labels Sep 13, 2024
@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 13, 2024
@tutelaris
Copy link
Member Author

tutelaris commented Sep 13, 2024

Hey @rowlandgeoff , can you please re-review this PR? Thank you!

rowlandgeoff
rowlandgeoff approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@rowlandgeoff rowlandgeoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have removed access for the ent-search-application-backend team.

@tutelaris tutelaris merged commit 6ab7467 into elastic:main Sep 13, 2024
mergify bot pushed a commit that referenced this pull request Sep 13, 2024
@tutelaris @mergify
Change codeowners for enterprise-search (#40796)
1b3df51 
(cherry picked from commit 6ab7467)
@mergify mergify bot mentioned this pull request Sep 13, 2024
Merged
rowlandgeoff pushed a commit that referenced this pull request Sep 13, 2024
@mergify @tutelaris
Change codeowners for enterprise-search (#40796) (#40820)
aeea08a 
(cherry picked from commit 6ab7467)

Co-authored-by: Klim Markelov <klim.markelov@gmail.com>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rowlandgeoff rowlandgeoff rowlandgeoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tutelaris tutelaris

Labels

backport backport-8.x Automated backport to the 8.x branch with mergify needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tutelaris @kderusso @rowlandgeoff